Remove host parameter as obligatory in SFTPStorage #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 1, 2020 09:49
This allows the SFTP_STORAGE_HOST setting to actually be used.
mlazowik
pushed a commit
to qedsoftware/django-storages
that referenced
this pull request
Mar 9, 2022
* Remove host parameter as obligatory in SFTPStorage This allows the SFTP_STORAGE_HOST setting to actually be used. * Fix tests: make hostname a keyword argument * Fix typo: hostname -> host Co-authored-by: Lode Rosseel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the SFTP_STORAGE_HOST setting to actually be used.
In the current implementation, the host=None in init causes the host attribute on SFTPStorage to always revert to None if using the DEFAULT_FILE_STORAGE setting in Django. Removing the default value for host in the init signature allows the default parameter from SFTP_STORAGE_HOST to be applied.